DOM update MessageEventTarget missed this parameters by sandersn · Pull Request #61086 · microsoft/TypeScript

sandersn · 2025-01-30T23:33:36Z

While trying to update typescript-dom-lib-generator so that it generates the correct types for MessageEventTarget's this parameters, I realised that my manual fix missed a couple. They're not required to make the known problem code in DT/top400 compile, but all the this parameters should have consistent types.

Of course, the whole thing is so fragile that I want to run tests as I figure out how to make dom-lib-generator generate the correct types, so that I can know if I need an even-more-complex fix.

sandersn · 2025-01-30T23:33:44Z

@typescript-bot test this

typescript-bot · 2025-01-30T23:33:48Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-01-30T23:54:45Z

@sandersn Here are the results of running the user tests with tsc comparing main and refs/pull/61086/merge:

Everything looks good!

typescript-bot · 2025-01-30T23:56:57Z

Hey @sandersn, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-01-31T00:18:54Z

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,436k (± 0.98%)}	_{194,935k (± 1.02%)}	_~	_193,110k	_196,794k	_{p=0.689 n=6}
_{Parse Time}	_{1.31s (± 0.39%)}	_{1.31s (± 1.48%)}	_~	_1.27s	_1.32s	_{p=0.929 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.75s (± 0.31%)}	_{9.77s (± 0.47%)}	_~	_9.71s	_9.82s	_{p=0.467 n=6}
_{Emit Time}	_{2.73s (± 0.59%)}	_{2.73s (± 0.94%)}	_~	_2.70s	_2.77s	_{p=1.000 n=6}
_{Total Time}	_{14.52s (± 0.22%)}	_{14.54s (± 0.39%)}	_~	_14.46s	_14.61s	_{p=0.809 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,488	_948,488	_~	_~	_~	_{p=1.000 n=6}
_Types	_411,006	_411,006	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,430k (± 0.00%)}	_{1,225,430k (± 0.00%)}	_~	_1,225,368k	_1,225,476k	_{p=0.936 n=6}
_{Parse Time}	_{6.63s (± 0.93%)}	_{6.63s (± 1.04%)}	_~	_6.53s	_6.72s	_{p=1.000 n=6}
_{Bind Time}	_{1.89s (± 0.58%)}	_{1.89s (± 0.43%)}	_~	_1.88s	_1.90s	_{p=0.666 n=6}
_{Check Time}	_{32.01s (± 0.55%)}	_{31.93s (± 0.30%)}	_~	_31.83s	_32.09s	_{p=0.296 n=6}
_{Emit Time}	_{15.22s (± 0.46%)}	_{15.16s (± 0.89%)}	_~	_14.95s	_15.33s	_{p=0.371 n=6}
_{Total Time}	_{55.76s (± 0.33%)}	_{55.62s (± 0.35%)}	_~	_55.43s	_55.91s	_{p=0.230 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,447,088	_2,447,088	_~	_~	_~	_{p=1.000 n=6}
_Types	_898,553	_898,553	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,307,933k (± 0.00%)}	_{2,307,955k (± 0.00%)}	_~	_2,307,934k	_2,307,976k	_{p=0.230 n=6}
_{Parse Time}	_{8.93s (± 0.25%)}	_{8.93s (± 0.19%)}	_~	_8.91s	_8.96s	_{p=0.804 n=6}
_{Bind Time}	_{2.17s (± 0.35%)}	_{2.18s (± 0.24%)}	_~	_2.17s	_2.18s	_{p=0.247 n=6}
_{Check Time}	_{74.30s (± 0.57%)}	_{74.24s (± 0.46%)}	_~	_73.81s	_74.59s	_{p=1.000 n=6}
_{Emit Time}	_{0.28s (± 1.47%)}	_{0.28s (± 3.19%)}	_~	_0.27s	_0.29s	_{p=0.787 n=6}
_{Total Time}	_{85.68s (± 0.52%)}	_{85.63s (± 0.41%)}	_~	_85.20s	_85.95s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,397	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,607,988k (±14.42%)}	_{3,094,937k (± 0.01%)}	_{🔻+486,949k (+18.67%)}	_3,094,485k	_3,095,535k	_{p=0.005 n=6}
_{Parse Time}	_{6.65s (± 1.38%)}	_{6.82s (± 0.99%)}	_{+0.17s (+ 2.51%)}	_6.74s	_6.92s	_{p=0.020 n=6}
_{Bind Time}	_{2.17s (± 1.28%)}	_{2.16s (± 1.74%)}	_~	_2.09s	_2.20s	_{p=0.810 n=6}
_{Check Time}	_{42.74s (± 0.56%)}	_{42.91s (± 0.26%)}	_~	_42.77s	_43.08s	_{p=0.128 n=6}
_{Emit Time}	_{3.52s (± 3.20%)}	_{3.44s (± 2.24%)}	_~	_3.29s	_3.50s	_{p=0.470 n=6}
_{Total Time}	_{55.07s (± 0.70%)}	_{55.33s (± 0.25%)}	_~	_55.17s	_55.51s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,397	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,039,468k (± 9.76%)}	_{2,917,490k (±12.87%)}	_~	_2,431,883k	_3,160,702k	_{p=0.173 n=6}
_{Parse Time}	_{7.00s (± 1.21%)}	_{6.97s (± 1.54%)}	_~	_6.78s	_7.08s	_{p=0.748 n=6}
_{Bind Time}	_{2.14s (± 0.87%)}	_{2.14s (± 2.55%)}	_~	_2.10s	_2.24s	_{p=0.295 n=6}
_{Check Time}	_{42.82s (± 0.36%)}	_{42.72s (± 0.24%)}	_~	_42.59s	_42.88s	_{p=0.378 n=6}
_{Emit Time}	_{3.48s (± 2.14%)}	_{3.56s (± 5.93%)}	_~	_3.32s	_3.91s	_{p=0.575 n=6}
_{Total Time}	_{55.43s (± 0.54%)}	_{55.41s (± 0.25%)}	_~	_55.21s	_55.57s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,074	_263,074	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,881	_106,881	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,323k (± 0.01%)}	_{441,320k (± 0.01%)}	_~	_441,225k	_441,375k	_{p=0.936 n=6}
_{Parse Time}	_{2.91s (± 0.57%)}	_{2.90s (± 0.47%)}	_~	_2.88s	_2.92s	_{p=0.217 n=6}
_{Bind Time}	_1.11s	_1.11s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{15.78s (± 0.37%)}	_{15.81s (± 0.09%)}	_~	_15.80s	_15.84s	_{p=0.258 n=6}
_{Emit Time}	_{1.33s (± 0.79%)}	_{1.32s (± 0.88%)}	_~	_1.31s	_1.34s	_{p=0.619 n=6}
_{Total Time}	_{21.12s (± 0.23%)}	_{21.14s (± 0.09%)}	_~	_21.10s	_21.15s	_{p=0.466 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,867k (± 0.03%)}	_{371,757k (± 0.02%)}	_~	_371,675k	_371,824k	_{p=0.128 n=6}
_{Parse Time}	_{3.62s (± 1.58%)}	_{3.61s (± 0.79%)}	_~	_3.57s	_3.65s	_{p=0.567 n=6}
_{Bind Time}	_{1.99s (± 1.16%)}	_{1.98s (± 1.45%)}	_~	_1.94s	_2.01s	_{p=0.463 n=6}
_{Check Time}	_{20.43s (± 0.47%)}	_{20.47s (± 0.41%)}	_~	_20.38s	_20.59s	_{p=0.423 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.04s (± 0.40%)}	_{26.06s (± 0.39%)}	_~	_25.93s	_26.21s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,273,582	_3,273,568	_{-14 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,125,603	_1,125,603	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,347,508k (± 0.01%)}	_{3,347,417k (± 0.01%)}	_~	_3,347,145k	_3,347,750k	_{p=0.689 n=6}
_{Parse Time}	_{14.63s (± 0.27%)}	_{14.64s (± 0.53%)}	_~	_14.56s	_14.77s	_{p=1.000 n=6}
_{Bind Time}	_{4.60s (± 0.25%)}	_{4.61s (± 0.56%)}	_~	_4.58s	_4.65s	_{p=0.871 n=6}
_{Check Time}	_{91.22s (± 1.82%)}	_{89.70s (± 1.51%)}	_~	_88.59s	_91.74s	_{p=0.066 n=6}
_{Emit Time}	_{28.61s (± 3.31%)}	_{28.70s (± 3.04%)}	_~	_27.36s	_29.36s	_{p=0.748 n=6}
_{Total Time}	_{139.06s (± 1.43%)}	_{137.65s (± 1.08%)}	_~	_136.13s	_140.46s	_{p=0.173 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_292,552	_292,528	_{-24 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_119,125	_119,113	_{-12 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{446,025k (± 0.04%)}	_{446,139k (± 0.02%)}	_~	_446,062k	_446,325k	_{p=0.230 n=6}
_{Parse Time}	_{5.09s (± 0.93%)}	_{5.08s (± 1.12%)}	_~	_5.00s	_5.16s	_{p=0.630 n=6}
_{Bind Time}	_{2.21s (± 1.03%)}	_{2.22s (± 0.96%)}	_~	_2.18s	_2.24s	_{p=0.222 n=6}
_{Check Time}	_{23.58s (± 2.32%)}	_{23.49s (± 0.54%)}	_~	_23.34s	_23.70s	_{p=0.298 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{30.88s (± 1.78%)}	_{30.79s (± 0.41%)}	_~	_30.68s	_31.02s	_{p=0.298 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,448	_555,448	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,146	_186,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,591k (± 0.01%)}	_{494,650k (± 0.01%)}	_{+58k (+ 0.01%)}	_494,581k	_494,706k	_{p=0.045 n=6}
_{Parse Time}	_{3.41s (± 0.82%)}	_{3.41s (± 1.02%)}	_~	_3.37s	_3.45s	_{p=1.000 n=6}
_{Bind Time}	_{1.21s (± 1.71%)}	_{1.21s (± 1.21%)}	_~	_1.19s	_1.23s	_{p=0.622 n=6}
_{Check Time}	_{19.64s (± 0.34%)}	_{19.68s (± 0.22%)}	_~	_19.61s	_19.72s	_{p=0.372 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.26s (± 0.35%)}	_{24.29s (± 0.14%)}	_~	_24.24s	_24.34s	_{p=0.423 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-01-31T01:13:13Z

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61086/merge:

Everything looks good!

sandersn · 2025-01-31T17:23:14Z

matching dom lib generator PR: microsoft/TypeScript-DOM-lib-generator#1894

@typescript-bot test this

typescript-bot · 2025-01-31T17:23:19Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-01-31T17:46:05Z

@sandersn Here are the results of running the user tests with tsc comparing main and refs/pull/61086/merge:

Everything looks good!

typescript-bot · 2025-01-31T17:47:18Z

Hey @sandersn, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-01-31T18:16:32Z

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,348k (± 0.96%)}	_{194,331k (± 0.97%)}	_~	_193,100k	_196,770k	_{p=0.470 n=6}
_{Parse Time}	_{1.31s (± 0.39%)}	_{1.31s (± 0.94%)}	_~	_1.29s	_1.32s	_{p=1.000 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.76s (± 0.19%)}	_{9.75s (± 0.33%)}	_~	_9.72s	_9.80s	_{p=0.519 n=6}
_{Emit Time}	_{2.72s (± 0.63%)}	_{2.74s (± 1.02%)}	_~	_2.71s	_2.79s	_{p=0.329 n=6}
_{Total Time}	_{14.51s (± 0.20%)}	_{14.52s (± 0.28%)}	_~	_14.49s	_14.59s	_{p=0.804 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,488	_948,488	_~	_~	_~	_{p=1.000 n=6}
_Types	_411,006	_411,006	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,654k (± 0.00%)}	_{1,225,645k (± 0.00%)}	_~	_1,225,585k	_1,225,679k	_{p=0.574 n=6}
_{Parse Time}	_{7.99s (± 1.03%)}	_{8.02s (± 1.42%)}	_~	_7.90s	_8.13s	_{p=0.872 n=6}
_{Bind Time}	_{2.28s (± 0.77%)}	_{2.29s (± 0.33%)}	_~	_2.28s	_2.30s	_{p=0.325 n=6}
_{Check Time}	_{38.34s (± 0.71%)}	_{38.26s (± 0.39%)}	_~	_38.07s	_38.39s	_{p=0.378 n=6}
_{Emit Time}	_{18.33s (± 0.28%)}	_{18.26s (± 0.51%)}	_~	_18.14s	_18.38s	_{p=0.229 n=6}
_{Total Time}	_{66.95s (± 0.26%)}	_{66.83s (± 0.26%)}	_~	_66.62s	_67.05s	_{p=0.199 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,447,455	_2,447,455	_~	_~	_~	_{p=1.000 n=6}
_Types	_898,654	_898,654	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,309,915k (± 0.00%)}	_{2,309,915k (± 0.00%)}	_~	_2,309,894k	_2,309,938k	_{p=1.000 n=6}
_{Parse Time}	_{8.94s (± 0.19%)}	_{8.92s (± 0.20%)}	_~	_8.90s	_8.95s	_{p=0.164 n=6}
_{Bind Time}	_{2.18s (± 0.69%)}	_{2.17s (± 0.24%)}	_~	_2.17s	_2.18s	_{p=1.000 n=6}
_{Check Time}	_{74.40s (± 0.58%)}	_{74.33s (± 0.25%)}	_~	_74.06s	_74.51s	_{p=0.575 n=6}
_{Emit Time}	_{0.27s (± 1.89%)}	_{0.28s (± 2.70%)}	_~	_0.27s	_0.29s	_{p=0.247 n=6}
_{Total Time}	_{85.79s (± 0.51%)}	_{85.70s (± 0.23%)}	_~	_85.42s	_85.89s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,397	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,851,822k (±13.21%)}	_{2,973,361k (±10.02%)}	_~	_2,364,477k	_3,096,666k	_{p=0.936 n=6}
_{Parse Time}	_{6.70s (± 1.74%)}	_{6.75s (± 1.05%)}	_~	_6.61s	_6.79s	_{p=1.000 n=6}
_{Bind Time}	_{2.15s (± 1.02%)}	_{2.12s (± 1.05%)}	_~	_2.09s	_2.15s	_{p=0.092 n=6}
_{Check Time}	_{42.65s (± 0.34%)}	_{42.76s (± 0.28%)}	_~	_42.58s	_42.94s	_{p=0.173 n=6}
_{Emit Time}	_{3.49s (± 3.20%)}	_{3.48s (± 1.04%)}	_~	_3.44s	_3.52s	_{p=0.810 n=6}
_{Total Time}	_{55.01s (± 0.46%)}	_{55.13s (± 0.29%)}	_~	_54.87s	_55.38s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,397	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,429,412k (± 0.02%)}	_{2,550,535k (±11.62%)}	_~	_2,428,616k	_3,156,251k	_{p=0.936 n=6}
_{Parse Time}	_{5.47s (± 0.77%)}	_{5.46s (± 1.13%)}	_~	_5.40s	_5.57s	_{p=0.470 n=6}
_{Bind Time}	_{1.78s (± 1.11%)}	_{1.79s (± 1.39%)}	_~	_1.76s	_1.82s	_{p=0.411 n=6}
_{Check Time}	_{35.35s (± 0.24%)}	_{35.41s (± 0.34%)}	_~	_35.29s	_35.64s	_{p=0.378 n=6}
_{Emit Time}	_{3.03s (± 1.21%)}	_{3.06s (± 1.41%)}	_~	_3.02s	_3.13s	_{p=0.378 n=6}
_{Total Time}	_{45.64s (± 0.18%)}	_{45.72s (± 0.40%)}	_~	_45.56s	_46.07s	_{p=0.470 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,074	_263,074	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,881	_106,881	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,282k (± 0.02%)}	_{441,269k (± 0.02%)}	_~	_441,132k	_441,336k	_{p=0.810 n=6}
_{Parse Time}	_{2.90s (± 1.19%)}	_{2.88s (± 0.81%)}	_~	_2.85s	_2.92s	_{p=0.324 n=6}
_{Bind Time}	_{1.11s (± 0.37%)}	_{1.11s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=0.114 n=6}
_{Check Time}	_{15.79s (± 0.33%)}	_{15.81s (± 0.45%)}	_~	_15.73s	_15.92s	_{p=0.807 n=6}
_{Emit Time}	_{1.31s (± 1.15%)}	_{1.32s (± 0.88%)}	_~	_1.31s	_1.34s	_{p=0.505 n=6}
_{Total Time}	_{21.10s (± 0.37%)}	_{21.13s (± 0.30%)}	_~	_21.08s	_21.24s	_{p=0.872 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,726k (± 0.01%)}	_{371,773k (± 0.04%)}	_~	_371,654k	_372,021k	_{p=1.000 n=6}
_{Parse Time}	_{3.61s (± 0.59%)}	_{3.60s (± 1.02%)}	_~	_3.55s	_3.64s	_{p=0.627 n=6}
_{Bind Time}	_{1.96s (± 0.91%)}	_{1.97s (± 0.75%)}	_~	_1.95s	_1.99s	_{p=0.256 n=6}
_{Check Time}	_{20.36s (± 0.40%)}	_{20.47s (± 0.30%)}	_{+0.11s (+ 0.52%)}	_20.37s	_20.54s	_{p=0.037 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{25.94s (± 0.32%)}	_{26.04s (± 0.40%)}	_~	_25.88s	_26.16s	_{p=0.092 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,273,541	_3,273,527	_{-14 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,125,648	_1,125,648	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,347,471k (± 0.01%)}	_{3,347,192k (± 0.01%)}	_~	_3,346,806k	_3,347,626k	_{p=0.230 n=6}
_{Parse Time}	_{17.98s (± 0.33%)}	_{18.00s (± 0.52%)}	_~	_17.86s	_18.10s	_{p=0.748 n=6}
_{Bind Time}	_{5.64s (± 0.21%)}	_{5.62s (± 0.33%)}	_{-0.02s (- 0.38%)}	_5.59s	_5.64s	_{p=0.048 n=6}
_{Check Time}	_{110.06s (± 2.08%)}	_{111.15s (± 1.43%)}	_~	_108.19s	_112.52s	_{p=0.471 n=6}
_{Emit Time}	_{33.64s (± 7.78%)}	_{34.82s (± 2.57%)}	_~	_33.48s	_35.77s	_{p=0.689 n=6}
_{Total Time}	_{167.33s (± 1.33%)}	_{169.59s (± 0.91%)}	_~	_166.90s	_171.24s	_{p=0.128 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_292,552	_292,528	_{-24 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_119,125	_119,113	_{-12 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{446,075k (± 0.03%)}	_{446,096k (± 0.02%)}	_~	_446,017k	_446,232k	_{p=0.936 n=6}
_{Parse Time}	_{4.10s (± 0.89%)}	_{4.08s (± 1.13%)}	_~	_4.04s	_4.17s	_{p=0.422 n=6}
_{Bind Time}	_{1.79s (± 1.64%)}	_{1.77s (± 0.97%)}	_~	_1.75s	_1.79s	_{p=0.167 n=6}
_{Check Time}	_{18.77s (± 0.62%)}	_{18.86s (± 0.59%)}	_~	_18.74s	_19.00s	_{p=0.173 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.67s (± 0.65%)}	_{24.72s (± 0.48%)}	_~	_24.60s	_24.88s	_{p=0.688 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,375	_555,375	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,146	_186,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,533k (± 0.01%)}	_{494,510k (± 0.01%)}	_~	_494,456k	_494,543k	_{p=0.810 n=6}
_{Parse Time}	_{3.41s (± 0.93%)}	_{3.42s (± 0.92%)}	_~	_3.37s	_3.46s	_{p=0.872 n=6}
_{Bind Time}	_{1.19s (± 1.06%)}	_{1.19s (± 1.06%)}	_~	_1.18s	_1.21s	_{p=1.000 n=6}
_{Check Time}	_{19.61s (± 0.47%)}	_{19.55s (± 0.28%)}	_~	_19.49s	_19.65s	_{p=0.296 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.21s (± 0.42%)}	_{24.16s (± 0.36%)}	_~	_24.04s	_24.30s	_{p=0.471 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-01-31T19:03:11Z

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61086/merge:

Everything looks good!

DOM update MessageEventTarget missed this parameters

abeb450

typescript-bot assigned sandersn Jan 31, 2025

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 31, 2025

also update webworker

8fd06c6

jakebailey approved these changes Feb 3, 2025

View reviewed changes

sandersn merged commit c50b5e7 into microsoft:main Feb 3, 2025
32 checks passed

sandersn removed this from PR Backlog Apr 22, 2025

microsoft locked as resolved and limited conversation to collaborators Oct 15, 2025

Conversation

sandersn commented Jan 30, 2025

Uh oh!

sandersn commented Jan 30, 2025

Uh oh!

typescript-bot commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 30, 2025

Uh oh!

typescript-bot commented Jan 30, 2025

Uh oh!

typescript-bot commented Jan 31, 2025

tsc

Uh oh!

typescript-bot commented Jan 31, 2025

Uh oh!

sandersn commented Jan 31, 2025

Uh oh!

typescript-bot commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 31, 2025

Uh oh!

typescript-bot commented Jan 31, 2025

Uh oh!

typescript-bot commented Jan 31, 2025

tsc

Uh oh!

typescript-bot commented Jan 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Jan 30, 2025 •

edited

Loading

typescript-bot commented Jan 31, 2025 •

edited

Loading